[browser] provide dummy icon and template icon #122775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
approved these changes
Dec 29, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dummy favicon to HTML files across WebAssembly browser tests, samples, and templates to eliminate 404 errors that appear in test logs when browsers automatically request /favicon.ico.
Key Changes
- Added inline base64-encoded favicon to all WASM/browser HTML files using a data URI
- Standardized favicon placement in the
<head>section across all files - Fixed trailing whitespace issues in several HTML files
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 25 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/FunctionalTests/WebAssembly/Browser/StartupHook/index.html | Added favicon link to test page |
| src/tests/FunctionalTests/WebAssembly/Browser/RuntimeConfig/index.html | Added favicon link to test page |
| src/tests/FunctionalTests/WebAssembly/Browser/HotReload/index.html | Added favicon link to test page |
| src/tests/Common/wasm-test-runner/index.html | Added favicon link to minified test runner |
| src/native/corehost/browserhost/sample/index.html | Added favicon link to browser host sample |
| src/mono/wasm/testassets/WasmOnAspNetCore/WasmBrowserClient/wwwroot/index.html | Added favicon link to test asset |
| src/mono/wasm/testassets/WasmOnAspNetCore/BlazorClient/wwwroot/index.html | Added favicon link to Blazor test client |
| src/mono/wasm/testassets/WasmBrowserRunMainOnly/wwwroot/index.html | Added favicon link and fixed trailing whitespace |
| src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/index.html | Added favicon link and fixed trailing whitespace |
| src/mono/wasm/testassets/LibraryMode/wwwroot/index.html | Added favicon link and fixed trailing whitespace |
| src/mono/wasm/templates/templates/browser/wwwroot/index.html | Added favicon link to WASM browser template and fixed trailing whitespace |
| src/mono/sample/wasm/simple-raytracer/wwwroot/index.html | Added favicon link and fixed trailing whitespace |
| src/mono/sample/wasm/browser/wwwroot/index.html | Added favicon link to browser sample |
| src/mono/sample/wasm/browser-threads/wwwroot/index.html | Added favicon link to threads sample |
| src/mono/sample/wasm/browser-shutdown/wwwroot/index.html | Added favicon link and fixed trailing whitespace |
| src/mono/sample/wasm/browser-profile/wwwroot/index.html | Added favicon link to profiler sample |
| src/mono/sample/wasm/browser-logprofile/wwwroot/index.html | Added favicon link to log profiler sample |
| src/mono/sample/wasm/browser-eventpipe/wwwroot/index.html | Added favicon link, fixed <br> formatting, and trailing whitespace |
| src/mono/sample/wasm/browser-bench/wwwroot/index.html | Added favicon link to benchmark sample |
| src/mono/sample/wasm/browser-bench/wwwroot/appstart-frame.html | Added favicon link to benchmark frame |
| src/mono/sample/wasm/browser-advanced/wwwroot/index.html | Added favicon link and fixed trailing whitespace |
| src/mono/sample/mbr/browser/wwwroot/index.html | Added favicon link to hot reload sample |
| src/mono/browser/test-index.html | Added favicon link to minified test index |
| src/coreclr/pal/tests/palsuite/wasm/index.html | Added favicon link to PAL tests |
| src/coreclr/hosts/corerun/wasm/corerun.html | Added favicon link to corerun page |
maraf
reviewed
Dec 29, 2025
This was referenced Jan 9, 2026
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
Contributor
|
@oroztocil backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: get rid of 404 for icon file
Using index info to reconstruct a base tree...
A src/coreclr/hosts/corerun/wasm/corerun.html
M src/coreclr/pal/tests/palsuite/wasm/index.html
A src/mono/browser/test-index.html
A src/mono/sample/mbr/browser/wwwroot/index.html
A src/mono/sample/wasm/browser-advanced/wwwroot/index.html
A src/mono/sample/wasm/browser-bench/wwwroot/appstart-frame.html
A src/mono/sample/wasm/browser-bench/wwwroot/index.html
A src/mono/sample/wasm/browser-eventpipe/wwwroot/index.html
A src/mono/sample/wasm/browser-logprofile/wwwroot/index.html
A src/mono/sample/wasm/browser-profile/wwwroot/index.html
A src/mono/sample/wasm/browser-shutdown/wwwroot/index.html
A src/mono/sample/wasm/browser-threads/wwwroot/index.html
A src/mono/sample/wasm/browser/wwwroot/index.html
A src/mono/sample/wasm/simple-raytracer/wwwroot/index.html
A src/mono/wasm/testassets/WasmBrowserRunMainOnly/wwwroot/index.html
A src/native/corehost/browserhost/sample/index.html
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/hosts/corewasmrun/index.html
CONFLICT (content): Merge conflict in src/coreclr/hosts/corewasmrun/index.html
Auto-merging src/coreclr/pal/tests/palsuite/wasm/index.html
CONFLICT (modify/delete): src/mono/browser/test-index.html deleted in HEAD and modified in get rid of 404 for icon file. Version get rid of 404 for icon file of src/mono/browser/test-index.html left in tree.
Auto-merging src/mono/sample/wasm/browser-bench/appstart-frame.html
Auto-merging src/mono/sample/wasm/browser-minimal-config/index.html
CONFLICT (modify/delete): src/mono/wasm/testassets/WasmBrowserRunMainOnly/wwwroot/index.html deleted in HEAD and modified in get rid of 404 for icon file. Version get rid of 404 for icon file of src/mono/wasm/testassets/WasmBrowserRunMainOnly/wwwroot/index.html left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 get rid of 404 for icon file
Error: The process '/usr/bin/git' failed with exit code 128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.