Fix unix x64 interpreter helpers CFI unwind info #122427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InterpreterStubRetXXX helpers on unix x64 had missing CFI annotation marking RBP as a frame pointer. Since they move RSP by dynamic value, the libunwind was unable to unwind through those, which was leading to crashes.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
davidwrighton
approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing CFI (Call Frame Information) unwind annotations for interpreter helper functions on unix x64. The fix adds set_cfa_register rbp, 0 directives to mark RBP as the Canonical Frame Address register in functions that dynamically adjust the stack pointer, enabling libunwind to properly unwind through these functions and preventing crashes.
Key Changes
- Added
set_cfa_register rbp, 0CFI directive after frame pointer setup in 9 CallJittedMethodRetXXX helper functions - Each annotation is placed immediately after
mov rbp, rspand before additional prologue instructions - Fixes apply uniformly to all variants handling different return types (void, buffers, integers, doubles, and combinations)
Member
Author
|
/ba-g the test failure is a variant of #119140, but in System.Runtime.Numerics.Tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InterpreterStubRetXXX helpers on unix x64 had missing CFI annotation marking RBP as a frame pointer. Since they move RSP by dynamic value, the libunwind was unable to unwind through those, which was leading to crashes.