Add cache setting to asset definition, use "force-cache" for fingerprinted assets #122101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
047ba0c to
3c3fb14
Compare
3c3fb14 to
7865c02
Compare
006cf01 to
dbc5c27
Compare
dbc5c27 to
52be9e4
Compare
javiercn
reviewed
Dec 5, 2025
maraf
reviewed
Dec 8, 2025
non-cached asset loads
af0bdee to
0012254
Compare
pavelsavara
reviewed
Dec 10, 2025
javiercn
reviewed
Dec 10, 2025
… It directly maps to fetchOptions.cache
pavelsavara
approved these changes
Dec 10, 2025
…hing-fix # Conflicts: # src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/BootJsonBuilderHelper.cs
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
The test case on main won't work, because that current state of Wasm.Build.Tests is
|
4 tasks
lewing
pushed a commit
that referenced
this pull request
Dec 11, 2025
…e" for fingerprinted assets (#122442) Backport of #122101 to release/10.0 to fix dotnet/aspnetcore#64009 ## Customer Impact - [x] Customer reported - [ ] Found internally The issue significantly effects startup time of every WebAssembly based application. ## Regression - [x] Yes - [ ] No Caused by #114901 ## Testing Manual testing of Blazor WebAssembly standalone, Blazor Web with WebAssembly & Auto interactivity, with Chromium-based, Firefox and Safari. Automated test. ## Risk Low. We are changing both built-time generator and runtime part reading the values. Thanks to fingerprinting there isn't a room for some staleness of one part. The change is scoped and in case it won't work in some scenario, the workaround is still possible. --------- Co-authored-by: Ondrej Roztocil <roztocil@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cacheto the definition of browser assets that allows specifying caching behavior when fetching the asset.cachesetting if set. If not set, previous behavior is kept as fallback (i.e. "no-cache" is used unless disabled by user).These changes are intended to mitigate the regression in Blazor WebAssembly loading performance introduced in .NET 10 due to the removal of the custom asset cache.
Adds a new E2E test that checks that no requests are sent to the server for fingerprinted Wasm assemblies on subsequent page reloads. A new Blazor Web application sample is added to support this test.
Contributes to dotnet/aspnetcore#64009