Skip to content

Conversation

@kotlarmilos
Copy link
Member

Description

This PR adds two smoke functional tests - one for R2R and one for the interpreter.

Copilot AI review requested due to automatic review settings November 28, 2025 13:09
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two smoke functional tests for iOS CoreCLR: one for Ready-to-Run (R2R) and one for the interpreter. The changes include creating new test project files, a shared test program, and consolidating R2R configuration properties to make them reusable across Apple platform builds.

Key changes:

  • New R2R and interpreter test projects in src/tests/FunctionalTests/iOS/Device/CoreCLR/
  • Consolidation of R2R properties (PublishReadyToRunComposite and PublishReadyToRunContainerFormat) from mono/sample/iOS/Program.csproj to AppleBuild.props for reusability
  • Updated test project paths in tests.proj from Simulator to Device directory

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
iOS.Simulator.CoreCLR.R2R.csproj New R2R test project with PublishReadyToRun enabled and proper CrossGen2 imports
iOS.Simulator.CoreCLR.Interpreter.Test.csproj Modified interpreter test project with environment variable removed
Program.cs New simple smoke test program that returns exit code 42
mono/sample/iOS/Program.csproj R2R properties moved to AppleBuild.props for better reusability
AppleBuild.props Added centralized R2R properties for CoreCLR on Apple platforms
tests.proj Updated test paths from Simulator/CoreCLR.Interpreter to Device/CoreCLR

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@kotlarmilos kotlarmilos added os-ios Apple iOS area-CodeGen-Interpreter-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 3, 2025
@kotlarmilos
Copy link
Member Author

This PR is ready for review - please take a look.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@kotlarmilos kotlarmilos enabled auto-merge (squash) December 5, 2025 08:03
@kotlarmilos
Copy link
Member Author

/ba-g helix timeouts

@kotlarmilos kotlarmilos merged commit 2fb929b into dotnet:main Dec 5, 2025
120 of 127 checks passed
kotlarmilos added a commit that referenced this pull request Dec 8, 2025
)

## Description

Targets in AppleBuild.InTree.targets were removed by mistake in
#122036. This change restores them
and fixes the performance jobs.

Internal performance job:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2856228&view=results
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants