-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix source map URLs for .NET 10 VMR builds #121923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix source map URLs for .NET 10 VMR builds #121923
Conversation
Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes source map URLs for .NET 10 builds to work with the new VMR (Virtual Monolithic Repository) structure. Since .NET 10 now builds from dotnet/dotnet instead of dotnet/runtime, the source map URLs need to be updated to point to the correct repository and include the src/runtime/ path prefix.
- Updated source map URL generation in two rollup configuration files
- Changed repository reference from
dotnet/runtimetodotnet/dotnetwithsrc/runtime/path prefix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/native/rollup.config.plugins.js |
Updated sourcemapPathTransform function to generate VMR-relative GitHub URLs with /src/runtime/ path prefix for CI builds |
src/mono/browser/runtime/rollup.config.js |
Updated sourcemapPathTransform function to generate VMR-relative GitHub URLs with /src/runtime/ path prefix for CI builds |
|
/backport to release/10.0 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Backport of #121923 ## Customer Impact - [x] Customer reported: #121804 - [ ] Found internally .NET 10 builds from the VMR (dotnet/dotnet) instead of dotnet/runtime. Source maps generated during CI builds were pointing to the old repository, causing 404 errors when browser debuggers attempted to load TypeScript sources. ## Regression - [X] Yes - [ ] No This regressed when the official runtime build moved to happen in the VMR. ## Testing Local testing to make sure the correct URL is produced. ## Risk Low. This only affects debugging scenarios.
.NET 10 builds from the VMR (dotnet/dotnet) instead of dotnet/runtime. Source maps generated during CI builds were pointing to the old repository, causing 404 errors when browser debuggers attempted to load TypeScript sources.
Changes
Updated
sourcemapPathTransformin rollup configurations to generate VMR-relative URLs:src/mono/browser/runtime/rollup.config.jssrc/native/rollup.config.plugins.jsFixes #121672
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.