Augment ArgumentOutOfRangeException tests for removed constraint #119263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the test coverage for ArgumentOutOfRangeException.ThrowIfEqual and ArgumentOutOfRangeException.ThrowIfNotEqual methods following the removal of IEquatable constraints in PR #118291. The changes add test cases for types that don't implement IEquatable to ensure the methods work correctly with the relaxed type constraints.
Key changes:
- Added test cases for nullable value types (
int?) - Added test cases for enum types (
ConsoleKey) - Verified both throwing and non-throwing scenarios for these new type categories
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
4 tasks
stephentoub
approved these changes
Sep 2, 2025
tannergooding
approved these changes
Sep 2, 2025
filipnavara
pushed a commit
to filipnavara/runtime
that referenced
this pull request
Sep 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #118291 that augments the tests to exercise the removed IEquatable constraint on ArgumentOutOfRangeException.ThrowIfEqual and ArgumentOutOfRangeException.ThrowIfNotEqual.