JIT: Remove LclVarDsc::GetArgReg and LclVarDsc::GetOtherArgReg uses#112652
Merged
jakobbotsch merged 2 commits intodotnet:mainfrom Feb 19, 2025
Merged
JIT: Remove LclVarDsc::GetArgReg and LclVarDsc::GetOtherArgReg uses#112652jakobbotsch merged 2 commits intodotnet:mainfrom
LclVarDsc::GetArgReg and LclVarDsc::GetOtherArgReg uses#112652jakobbotsch merged 2 commits intodotnet:mainfrom
Conversation
Switch these to use new ABI info. The only uses left are in logging and in the old ABI classification happening during `lvaInitUserArgs`. Once we remove uses of all the information stored there we can get rid of the fields entirely.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
commented
Feb 18, 2025
Comment on lines
-1622
to
-1627
| bool isRegCandidate = compiler->compEnregStructLocals() && !varDsc->HasGCPtr(); | ||
| #if defined(TARGET_LOONGARCH64) || defined(TARGET_RISCV64) | ||
| // The LoongArch64's ABI which the float args within a struct maybe passed by integer register | ||
| // when no float register left but free integer register. | ||
| isRegCandidate &= !genIsValidFloatReg(varDsc->GetOtherArgReg()); | ||
| #endif |
Member
Author
There was a problem hiding this comment.
@dotnet/samsung @shushanhf This special case should already be handled by this code:
runtime/src/coreclr/jit/lclvars.cpp
Lines 4022 to 4026 in 6e06aef
Can you please confirm that this looks ok to remove?
Member
Author
EgorBo
approved these changes
Feb 19, 2025
tomeksowi
approved these changes
Feb 19, 2025
grendello
pushed a commit
to grendello/runtime
that referenced
this pull request
Feb 19, 2025
…es (dotnet#112652) Switch these to use new ABI info. The only uses left are in logging and in the old ABI classification happening during `lvaInitUserArgs`. Once we remove uses of all the information stored there we can get rid of the fields entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch these to use new ABI info.
The only uses left are in logging and in the old ABI classification happening during
lvaInitUserArgs. Once we remove uses of all the information stored there we can get rid of the fields entirely.