Skip to content

[browser] fix code gen overflow #110539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 1 commit into from
Dec 10, 2024
Merged

[browser] fix code gen overflow #110539

pavelsavara merged 1 commit into from
Dec 10, 2024

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 9, 2024

Fixes #84996

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Dec 9, 2024
@pavelsavara pavelsavara added this to the 10.0.0 milestone Dec 9, 2024
@pavelsavara pavelsavara self-assigned this Dec 9, 2024
@build-analysis build-analysis bot mentioned this pull request Dec 9, 2024
Closed
3 tasks
@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 10, 2024

image

@pavelsavara pavelsavara marked this pull request as ready for review December 10, 2024 09:15
@pavelsavara pavelsavara requested a review from lewing as a code owner December 10, 2024 09:15
@pavelsavara pavelsavara requested a review from maraf December 10, 2024 09:15
@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 10, 2024

/ba-g pipeline timeouts

@pavelsavara pavelsavara merged commit 1fa2361 into dotnet:main Dec 10, 2024
30 of 33 checks passed
@pavelsavara pavelsavara deleted the js_gen_fix_hash branch December 10, 2024 09:42
@jkotas jkotas mentioned this pull request Dec 11, 2024
Closed
jkotas added a commit that referenced this pull request Dec 11, 2024
@jkotas
Revert "[browser] fix code gen overflow (#110539)"
c07a81e 
This reverts commit 1fa2361.
@jkotas jkotas mentioned this pull request Dec 11, 2024
Merged
MichalStrehovsky pushed a commit that referenced this pull request Dec 11, 2024
@jkotas
Revert "[browser] fix code gen overflow (#110539)" (#110599)
878e5d7 
This reverts commit 1fa2361.
pavelsavara added a commit to pavelsavara/runtime that referenced this pull request Dec 11, 2024
@pavelsavara
Reapply "[browser] fix code gen overflow (dotnet#110539)" (dotnet#110599
78f9961 
)

This reverts commit 878e5d7.
@pavelsavara pavelsavara mentioned this pull request Dec 11, 2024
Merged
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
@pavelsavara @hez2010
[browser] fix code gen overflow (dotnet#110539)
40014b6
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
@jkotas @hez2010
Revert "[browser] fix code gen overflow (dotnet#110539)" (dotnet#110599)
2579b1e 
This reverts commit 1fa2361.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

JSSignatureContext.cs may include incorrect use of Math.Abs

3 participants

@pavelsavara @akoeplinger @ilonatommy