Update unhandled exception handler API to match approved shape. #110254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
1 similar comment
|
Note regarding the |
jkotas
reviewed
Nov 28, 2024
3 tasks
jkotas
requested changes
Nov 29, 2024
Member
jkotas
left a comment
There was a problem hiding this comment.
This needs more changes to fix build breaks.
Member
|
Test.CoreLib is a limited runtime and does not have Func delegates declared as they were not needed so far. This change needs that at least Func`2 is declared in the test lib. |
jkotas
reviewed
Nov 29, 2024
This reverts commit 72f772e.
This was referenced Nov 29, 2024
jkotas
reviewed
Nov 30, 2024
src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/__Finalizer.cs
Outdated
Show resolved
Hide resolved
eduardo-vp
pushed a commit
to eduardo-vp/runtime
that referenced
this pull request
Dec 5, 2024
…et#110254) * Update unhandled exception handler API to match approved shape. * Update the correct API in the reference assembly. * IsHandledByGlobalHandler helper --------- Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
…et#110254) * Update unhandled exception handler API to match approved shape. * Update the correct API in the reference assembly. * IsHandledByGlobalHandler helper --------- Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #109806 (comment)