Skip to content

Replace DAMT.All with DAMT.AllMethods in delegate creation #109772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 1 commit into from
Nov 13, 2024
Merged

Replace DAMT.All with DAMT.AllMethods in delegate creation #109772

MichalStrehovsky merged 1 commit into from
Nov 13, 2024

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Nov 13, 2024

DynamicallyAccessedMemberTypes.All can be replaced with the newly added AllMethods since it has the right semantics (keep privates in base types).

Cc @dotnet/illink @eerhardt

@MichalStrehovsky MichalStrehovsky added the linkable-framework Issues associated with delivering a linker friendly framework label Nov 13, 2024
@ghost
Copy link

ghost commented Nov 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Nov 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Nov 13, 2024

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Nov 13, 2024
Open
3 tasks
eerhardt
eerhardt approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Are there any upstream callers that can be changed from All to AllMethods? I’m not sure an easy way to check. It might be nice if the analyzer had an option to alert when you are preserving too much.

This was referenced Nov 13, 2024
Open
Open
Open
Closed
Open
@MichalStrehovsky MichalStrehovsky mentioned this pull request Nov 13, 2024
Closed
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Nov 13, 2024

Are there any upstream callers that can be changed from All to AllMethods?

I did a search in this repo - we don't use these overloads.

I’m not sure an easy way to check. It might be nice if the analyzer had an option to alert when you are preserving too much.

Yup, would be a nice feature! Cc @dotnet/illink

@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented Nov 13, 2024

/ba-g the only not-known-issues are timeouts in unrelated tests

@MichalStrehovsky MichalStrehovsky merged commit 38e4ba6 into dotnet:main Nov 13, 2024
@MichalStrehovsky MichalStrehovsky deleted the useAllMethods branch November 13, 2024 21:42
@sbomer sbomer mentioned this pull request Nov 13, 2024
Open
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Closed
@jtschuster jtschuster mentioned this pull request Nov 14, 2024
Closed
@MichalStrehovsky MichalStrehovsky mentioned this pull request Nov 15, 2024
Merged
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@MichalStrehovsky @mikelle-rogers
Replace DAMT.All with DAMT.AllMethods in delegate creation (dotnet#10…
8610ed7 
…9772)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner

Assignees

@MichalStrehovsky MichalStrehovsky

Labels

area-System.Reflection linkable-framework Issues associated with delivering a linker friendly framework new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky @eerhardt