Skip to content

[browser] Fix custom icu fingerprinting. #108011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilonatommy merged 3 commits into from
Sep 19, 2024
Merged

[browser] Fix custom icu fingerprinting. #108011

ilonatommy merged 3 commits into from
Sep 19, 2024

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Sep 19, 2024 •
edited
Loading

Using custom ICU files got broken with fingerprinting.
Repro:

<BlazorIcuDataFileName>/workspaces/runtime/artifacts-samples/browser/icudt_custom.dat</BlazorIcuDataFileName>

produces boot.config.json:

  "mainAssemblyName": "browser",
  "resources": {
    "hash": "sha256-mDtUMfPuXPyYADO8g8Kk3TOZPMhbHv/IMatrIfcVy8M=",
    "fingerprinting": {
         ...........
        "icudt_custom.oh1zvcfom8.dat": "icudt_custom.dat",
     },
    "icu": {
      "icudt_custom.oh1zvcfom8.dat": "sha256-tO5O5YzMTVSaKBboxAqezOQL9ewmupzV2JrB5Rkc8a4="
    },
   }
  "globalizationMode": "custom"

fileMapping has contents: mapping={ "icudt_custom.dat": "icudt_custom.oh1zvcfom8.dat" }
icuFile has a value icudt_custom.oh1zvcfom8.dat.
So we won't enter the condition:

        if (icuFile && fileMapping[icuFile]) {
            return fileMapping[icuFile];
        }

and would finish with invariant mode that prevents globalization methods from working.

ToDo:
should be backported to net9.

@ilonatommy ilonatommy requested a review from maraf September 19, 2024 10:42
@ilonatommy ilonatommy self-assigned this Sep 19, 2024
pavelsavara
pavelsavara reviewed Sep 19, 2024
View reviewed changes
@ilonatommy @pavelsavara
Update src/mono/browser/runtime/loader/icu.ts
21a8495 
Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>
@ilonatommy ilonatommy mentioned this pull request Sep 19, 2024
Closed
1 task
This was referenced Sep 19, 2024
Open
Open
@ilonatommy ilonatommy merged commit 4d37f40 into dotnet:main Sep 19, 2024
@ilonatommy
Copy link
Member Author

ilonatommy commented Sep 19, 2024

/backport to release/9.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Started backporting to release/9.0-rc2: https://github.com/dotnet/runtime/actions/runs/10944660037

@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Merged
4 tasks
@tarekgh tarekgh added the arch-wasm WebAssembly architecture label Sep 23, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Sep 23, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@ilonatommy @pavelsavara @sirntar
[browser] Fix custom icu fingerprinting. (dotnet#108011)
899dbfb 
* Fix custom icu fingerprinting.

* Update src/mono/browser/runtime/loader/icu.ts

Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>

---------

Co-authored-by: Pavel Savara <pavelsavara@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara left review comments

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@ilonatommy ilonatommy

Labels

arch-wasm WebAssembly architecture area-System.Globalization

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy @pavelsavara @maraf @tarekgh