Put handling of sized ref handles under FEATURE_SIZED_REF_HANDLES #107326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
jkotas
reviewed
Sep 4, 2024
jkotas
approved these changes
Sep 4, 2024
Member
jkotas
left a comment
There was a problem hiding this comment.
LGTM. @dotnet/gc should sign-off as well.
Member
|
This can be deleted as well: https://github.com/dotnet/runtime/blob/main/src/coreclr/vm/gchandleutilities.h#L129-L144 |
Maoni0
approved these changes
Sep 4, 2024
3 tasks
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Sep 6, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
… defined (dotnet#107433) Regression from dotnet#107326 - without `FEATURE_SIZED_REF_HANDLES` defined, this was incorrectly passing an array of two handle types - HNDTYPE_STRONG and HNDTYPE_WEAK_SHORT (0) - when promoting objects pointed to by strong handles.
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
… defined (dotnet#107433) Regression from dotnet#107326 - without `FEATURE_SIZED_REF_HANDLES` defined, this was incorrectly passing an array of two handle types - HNDTYPE_STRONG and HNDTYPE_WEAK_SHORT (0) - when promoting objects pointed to by strong handles.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #107106 (comment)
cc @dotnet/gc @jkotas @AaronRobinsonMSFT