[release/9.0] Ensure that Vector128.CreateSequence works on x86 for non-constant 64-bit inputs #107147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
CC. @dotnet/jit-contrib, @EgorBo |
EgorBo
approved these changes
Aug 29, 2024
Member
|
Closed and reopened to get CI to start, its going now |
jeffschwMSFT
approved these changes
Aug 29, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we can merge when ready
This was referenced Aug 30, 2024
Member
|
@tannergooding can you take a look at the PR failures? |
Member
|
@jeffschwMSFT, they are unrelated flaky tests and passed on rerun. -- They are variations of the general |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107053 to release/9.0
/cc @tannergooding
Customer Impact
Found by Antigen: #106372
Developers using the new vector
CreateSequenceAPI forlongorulongon an x86 machine would see incorrect results.Regression
This is a new API in .NET 9 and a scenario that was missed for non-constant inputs on 32-bit hardware.
Testing
An explicit regression test was added and additional code paths were checked to ensure they were correctly handling the inputs.
Risk
Low. This is a net new API in .NET 9 and is simply falling back to the managed code path for 32-bit hardware, as expected.