Code cleanup: Replace TODO with Note in assertionprop regarding using a precise range for IntegralRange#106982
Merged
JulieLeeMSFT merged 1 commit intodotnet:mainfrom Aug 27, 2024
Merged
Conversation
…for IntegralRnage.
Member
Author
|
cc @dotnet/jit-contrib. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Aug 26, 2024
Member
EgorBo
left a comment
There was a problem hiding this comment.
Yeah I think it's fine for this quick function to return non-precise ranges. For precise ranges with have rangecheck and optAssertionProp_RangeProperties VN/Assertprop based.
Open
3 tasks
Member
Author
|
/ba-g test failures are not relevant to this PR because it changes comments only. |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…for IntegralRnage. (dotnet#106982)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the TODO-Casts comment with Note because there seems no advantages of using precise range for IntegralRange over non-precise ranges.
For example, for a IntCns constant of 42, the current non-precise range returns [0..127], where TODO expected to get [42,42].
The current JIT doesn't have any optimizations that could benefit from a precise range.