Enable CommittedUsage event for segments #106831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
Maoni0
reviewed
Aug 22, 2024
Maoni0
approved these changes
Aug 22, 2024
Member
Maoni0
left a comment
There was a problem hiding this comment.
other than the comment above this LGTM
This was referenced Aug 22, 2024
86129de to
ff5759a
Compare
ff5759a to
eda5f37
Compare
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have got the commit accounting right, we can take advantage of it to fire the
CommittedUsageevent. This will allow us to make meaningful comparison between segments and regions with respect to committed memory usage.