Skip to content

Remove managed interfaces impls defined in CoreCLR #105965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AaronRobinsonMSFT merged 13 commits into from
Aug 17, 2024
Merged

Remove managed interfaces impls defined in CoreCLR #105965

AaronRobinsonMSFT merged 13 commits into from
Aug 17, 2024

Conversation

@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Aug 5, 2024 •
edited
Loading

The IReflect implementation can be removed since we missed a supporting type after we brought this back in dotnet/coreclr#21343. The supporting type is System.Runtime.InteropServices.ComTypes.IReflect, which is needed for it to work at all. Thus, this scenario has never worked in .NET Core.

Implement IDynamicInterfaceCastable on __ComObject to avoid managed interface definitions in unmanaged code - IEnumerable and IEnumerator. In an effort to ensure existing users are supported, ICustomAdapter is available when either of the previous two are supported. This allows us to remove the FCall forwarders that simulated a type of DIM for RCWs that implemented a conforming IDispatch or IEnumVARIANT.

Verified that EnumerableToDispatchMarshaler is not emitted by TlbImp.

@ghost ghost added the area-VM-coreclr label Aug 5, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 5, 2024

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

This was referenced Aug 5, 2024
Open
Open
Open
Closed
This was referenced Aug 12, 2024
Closed
Closed
Closed
This was referenced Aug 13, 2024
Open
Closed
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Aug 14, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review August 14, 2024 23:55
@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Aug 15, 2024

/cc @dotnet/interop-contrib

jkotas
jkotas approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

elinor-fung
elinor-fung reviewed Aug 16, 2024
View reviewed changes
AaronRobinsonMSFT
AaronRobinsonMSFT commented Aug 16, 2024
View reviewed changes
elinor-fung
elinor-fung approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 0d8e565 into dotnet:main Aug 17, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the remove_managed_interfaces_in_runtime branch August 17, 2024 00:12
This was referenced Aug 19, 2024
Closed
Merged
AaronRobinsonMSFT added a commit to AaronRobinsonMSFT/runtime that referenced this pull request Aug 20, 2024
@AaronRobinsonMSFT
Grab back some performance in RuntimeTypeHandle::GetElementType
2e19ab1 
It appears that after dotnet#105965, the
compiler is no longer inlining `TypeHandle::IsArray` for
this code path. This deconstructs that use and reclaims it.
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Aug 20, 2024
Merged
AaronRobinsonMSFT added a commit that referenced this pull request Aug 21, 2024
@AaronRobinsonMSFT
Grab back some performance in RuntimeTypeHandle::GetElementType (#1…
a3cbf8c 
…06730)

It appears that after #105965, the
compiler is no longer inlining `TypeHandle::IsArray` for
this code path. This deconstructs that use and reclaims it.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
@AaronRobinsonMSFT AaronRobinsonMSFT added breaking-change Issue or PR that represents a breaking API or functional change over a previous release. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Nov 15, 2025
@AaronRobinsonMSFT
Copy link
Member Author

AaronRobinsonMSFT commented Nov 15, 2025

Breaking change issue filed at dotnet/docs#49921

@AaronRobinsonMSFT AaronRobinsonMSFT removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels

area-Interop-coreclr breaking-change Issue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AaronRobinsonMSFT @jkotas @elinor-fung