Skip to content

Http2Connection throws misleading exceptions on ping timeouts #102691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MihaZupan merged 4 commits into from
May 27, 2024
Merged

Http2Connection throws misleading exceptions on ping timeouts #102691

MihaZupan merged 4 commits into from
May 27, 2024

Conversation

@pedrobsaila
Copy link
Contributor

@pedrobsaila pedrobsaila commented May 25, 2024

Fixes #102623

@ghost ghost added the area-System.Net.Http label May 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 25, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented May 25, 2024

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

MihaZupan
MihaZupan approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MihaZupan MihaZupan added this to the 9.0.0 milestone May 25, 2024
@MihaZupan
Copy link
Member

MihaZupan commented May 25, 2024

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented May 25, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request May 26, 2024
Closed
@jeffl8n jeffl8n mentioned this pull request May 26, 2024
Closed
@MihaZupan MihaZupan merged commit 2feae23 into dotnet:main May 27, 2024
@pedrobsaila pedrobsaila deleted the 102623 branch May 27, 2024 21:24
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@pedrobsaila @Ruihan-Yin
Http2Connection throws misleading exceptions on ping timeouts (dotnet…
5c5429e 
…#102691)

* Http2Connection throws misleading exceptions on ping timeouts

* fix unwanted diffs 1

* fix unwanted diffs 2

* fix remarks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees

No one assigned

Labels

area-System.Net.Http community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

Http2Connection throws misleading exceptions on ping timeouts

2 participants

@pedrobsaila @MihaZupan