Skip to content

Remove IgnoreExitCode from lld version check #102278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 1 commit into from
May 16, 2024
Merged

Remove IgnoreExitCode from lld version check #102278

MichalStrehovsky merged 1 commit into from
May 16, 2024

Conversation

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented May 15, 2024

Subset of #102000.

@MichalStrehovsky MichalStrehovsky requested a review from sbomer May 15, 2024 18:28
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented May 15, 2024

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky MichalStrehovsky mentioned this pull request May 15, 2024
Closed
sbomer
sbomer approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@build-analysis build-analysis bot mentioned this pull request May 15, 2024
Closed
@MichalStrehovsky
Copy link
Member Author

MichalStrehovsky commented May 16, 2024

/ba-g x64 native AOT legs timed out, infra paired it with #102239, but build analysis is still not green?

@MichalStrehovsky MichalStrehovsky merged commit 95ff499 into main May 16, 2024
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch May 16, 2024 04:52
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@MichalStrehovsky @Ruihan-Yin
Remove IgnoreExitCode from lld version check (dotnet#102278)
45c42ec 
Subset of dotnet#102000.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sbomer sbomer sbomer approved these changes

+1 more reviewer

@am11 am11 am11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MichalStrehovsky MichalStrehovsky

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichalStrehovsky @sbomer @am11