SPMI: Replay recorded allocPgoInstrumentationBySchema HRESULT #101696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current SPMI collection has a recorded allocPgoInstrumentationBySchema call that failed (EE returned 0x80004001). SPMI fails to replay that correctly. Fix dotnet#101685
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
kunalspathak
approved these changes
Apr 29, 2024
Contributor
kunalspathak
left a comment
There was a problem hiding this comment.
LGTM. do you know what change started causing this failure?
Member
|
I wonder if #101648 broke it |
EgorBo
approved these changes
Apr 29, 2024
Closed
Member
Author
I don't, no. I opened #101711 to check why it fails on the EE side. |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…#101696) Current SPMI collection has a recorded allocPgoInstrumentationBySchema call that failed (EE returned 0x80004001). SPMI fails to replay that correctly. Fix dotnet#101685
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…#101696) Current SPMI collection has a recorded allocPgoInstrumentationBySchema call that failed (EE returned 0x80004001). SPMI fails to replay that correctly. Fix dotnet#101685
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…#101696) Current SPMI collection has a recorded allocPgoInstrumentationBySchema call that failed (EE returned 0x80004001). SPMI fails to replay that correctly. Fix dotnet#101685
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current SPMI collection has a recorded
allocPgoInstrumentationBySchemacall that failed (EE returned 0x80004001). SPMI fails to replay that correctly.Fix #101685
It would also be good to understand why the allocation failed. 0x80004001 is
E_NOTIMPL, but that doesn't give much more information.cc @dotnet/jit-contrib