Skip to content

Fix x86 build with clang-18 #101650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 3 commits into from
Apr 28, 2024
Merged

Fix x86 build with clang-18 #101650

jkotas merged 3 commits into from
Apr 28, 2024

Conversation

@am11
Copy link
Member

@am11 am11 commented Apr 27, 2024

Fixes #101639.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 27, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 27, 2024

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@am11 am11 force-pushed the feature/build/linux-x86-clang18 branch from 2d67551 to fb71f82 Compare April 27, 2024 20:37
@am11 am11 marked this pull request as ready for review April 27, 2024 20:55
@am11 am11 force-pushed the feature/build/linux-x86-clang18 branch 2 times, most recently from 7203310 to e7a410a Compare April 27, 2024 22:01
@am11 am11 force-pushed the feature/build/linux-x86-clang18 branch from e7a410a to cdc7344 Compare April 28, 2024 14:16
@am11
Copy link
Member Author

am11 commented Apr 28, 2024

Since this diagnostic is buggy on various architectures (e.g. llvm/llvm-project#69146 (comment)), I've just suppressed it in the second commit. With first commit, while it was building in CI, testing R2R locally was throwing sigsegv.

cc @jkotas

jkotas
jkotas approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This was referenced Apr 28, 2024
Open
Closed
Closed
@jkotas
Copy link
Member

jkotas commented Apr 28, 2024

/ba-g slow mac

@jkotas jkotas merged commit c3e5ce9 into dotnet:main Apr 28, 2024
@richlander richlander mentioned this pull request Apr 30, 2024
Merged
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@am11 @matouskozak
Fix x86 build with clang-18 (dotnet#101650)
75f2b1b 
* Fix x86 build with clang-18

* Suppress Wsync-alignment

* Update x86 pipeline to use clang-18
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@am11 @michaelgsharp
Fix x86 build with clang-18 (dotnet#101650)
3c21537 
* Fix x86 build with clang-18

* Suppress Wsync-alignment

* Update x86 pipeline to use clang-18
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pal.h will not build with clang 18 for x86

2 participants

@am11 @jkotas