JIT: optimize popped boxes in the importer#101303
Merged
AndyAyersMS merged 2 commits intodotnet:mainfrom Apr 20, 2024
Merged
Conversation
Member
Author
|
@TIHan PTAL Didn't see any SPMI diffs from this, but the new test case ; Assembly listing for method Runtime_82291:GetValueOrNullSlow2[int]() (FullOpts)
; Emitting BLENDED_CODE for X64 with AVX - Windows
; FullOpts code
; optimized code
; rsp based frame
; partially interruptible
; No PGO data
; Final local variable assignments
;
;* V00 loc0 [V00 ] ( 0, 0 ) int -> zero-ref ld-addr-op
;# V01 OutArgs [V01 ] ( 1, 1 ) struct ( 0) [rsp+0x00] do-not-enreg[XS] addr-exposed "OutgoingArgSpace"
;* V02 tmp1 [V02 ] ( 0, 0 ) ref -> zero-ref class-hnd exact "Single-def Box Helper" <System.Int32>
;
; Lcl frame size = 0
G_M56457_IG01: ;; offset=0x0000
;; size=0 bbWeight=1 PerfScore 0.00
G_M56457_IG02: ;; offset=0x0000
ret
;; size=1 bbWeight=1 PerfScore 1.00
|
Member
Author
|
Failures are all known, but some not covered by build analysis. There were a handful of diffs after all: diffs |
TIHan
approved these changes
Apr 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82291.