Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 889404f
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5529dc7
Choose a head ref
  • 14 commits
  • 232 files changed
  • 15 contributors

Commits on Jul 7, 2022

  1. Improve objcopy detection (#71742)

    @am11
    am11 authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    34383d1 View commit details
    Browse the repository at this point in the history

  2. Update ILToNativeMap event to include IL version (#71479) 

    * Update eventtrace.cpp

* Add native code ID and IL code ID
    @davmason
    davmason authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    32ca998 View commit details
    Browse the repository at this point in the history

  3. Make things work for arrays of function pointers (#71749) 

    * Don't try to obtain type handles for fields of types of function pointer arrays
* Add function pointer support to name mangler. We still don't make EETypes for these, but debug info generation also needs mangled names. We currently generate debug info for function pointers as debug info for `void*`, but arrays of function pointers only partially go through that handling and still end up needing a mangled name for the function pointer.
    @MichalStrehovsky
    MichalStrehovsky authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    7331be5 View commit details
    Browse the repository at this point in the history

  4. Reduce allocation overhead of Enumerable.Order{Descending} (#71564) 

    Enumerable.OrderBy{Descending} buffers the input into an array.  It then allocates a TKey[] from that input to store the keys, and allocates an int[] that's what's actually sorted based on those keys.  The enumerator uses that sorted int[] then to decide what element from the buffered input to yield next.  In the case of the new Order and OrderDescending methods, though, that TKey[] isn't required; it's just a copy of the buffered input, so we can avoid it.
    @stephentoub
    stephentoub authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    63e9379 View commit details
    Browse the repository at this point in the history

  5. [mono] Avoid calling mono_metadata_type_hash () on the container clas… 

    …s in mono_generic_class_hash (). (#71734)

If a class inherits from a generic instance instantiated with itself, then its possible
for mono_generic_class_hash () to be called while the container class is not fully
initialized yet, i.e. byval_arg.type is 0. This would cause the generic class to change
its hash.

Fixes #71424.
    @vargaz
    vargaz authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    cf94b83 View commit details
    Browse the repository at this point in the history

  6. Use scoped more in dotnet/runtime (#71589) 

    * Use scoped more in dotnet/runtime

This PR addresses a few issues:
- Exposes the new {ReadOnly}Span constructors that accept a ref.
- Uses those new constructors outside of corelib (they were previously internal and used only inside of corelib).
- Makes several members of Utf8JsonReader readonly in order to enable stackalloc'd spans to be used in ValueTextEquals calls.
- Makes several span arguments to SequenceReader scoped in order to enable stackalloc'd spans to be used with those calls.
- Removes all stackalloc T[0], replacing it with scoped locals.
- Removes some use of stackalloc'ing into a pointer and then manually wrapping into a span, instead directly stackalloc'ing into a span.  This is possible now in more cases due to the new language validation rules.
- Replaced some use of MemoryMarshal.GetReference(MemoryMarshal.CreateSpan(...)) with Unsafe.AsRef.

* Address PR feedback
    @stephentoub
    stephentoub authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    38ca26b View commit details
    Browse the repository at this point in the history

  7. Use ObjectDisposedException.ThrowIf in more places (#71546) 

    * Use ObjectDisposedException.ThrowIf in more places

* Update TarWriter.cs
    @stephentoub
    stephentoub authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9768606 View commit details
    Browse the repository at this point in the history

  8. #37093 disable Reciprocal test only for Android x86 (#71541) 

    * #37093 disable Reciprocal test only for Android x86
    @mkhamoyan
    mkhamoyan authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    8803e61 View commit details
    Browse the repository at this point in the history

  9. Add markdown readme for System.Collections.Immutable (#71247) 

    * Update System.Collections.Immutable.csproj

* Add README.md

* Add README.md

* Delete README.md

* Update PackageDescription
    @MSDN-WhiteKnight
    MSDN-WhiteKnight authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    21a69aa View commit details
    Browse the repository at this point in the history

  10. Move ICustomTypeMarshallingStrategy implementations into separate fil… 

    …es (#71747)

* Move ICustomTypeMarshallingStrategy implementations into separate files
* Remove constructor args from V2 marshalling strategy
    @elinor-fung
    elinor-fung authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3577c03 View commit details
    Browse the repository at this point in the history

  11. Fix incoming arg struct splitting (#71701) 

    This change only affects Windows/arm64 with varargs.

For incoming structs split between register and stack, handle the splitting
correctly.

Fixes #57606
    @BruceForstall
    BruceForstall authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    e633272 View commit details
    Browse the repository at this point in the history

  12. Unix arm64 atomics (#71512) 

    * Define_InterlockMethod macro

* compiler failure

* fix build errors

* Set g_arm64_atomics_present at common place

* Fix the missing declaration

* Change TARGET_ARM64 => HOST_ARM64

* Use LSE for InterlockedCompareExchange

* Attempt to fix osx-arm64 build issue

* Introduce LSE_INSTRUCTIONS_ENABLED_BY_DEFAULT

* Make sure that compiler knows that M1 has lse
    @kunalspathak
    kunalspathak authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    10286e9 View commit details
    Browse the repository at this point in the history

  13. [wasm] JSImport, JSExport and related API types for JavaScript interop ( 

    #71500)

- approved API
- xmldoc

Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Katelyn Gadd <kg@luminance.org>
    @pavelsavara @maraf @kg
    3 people authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    1206b82 View commit details
    Browse the repository at this point in the history

  14. [Mono] Fix all remaining C4018 warnings and enable the check during b… 

    …uild (#71269)

* 3rd round of fixing 4018 warnings

* Fix warnings on x86

* Fix remaining c4018 warnings and enable it for build

* Fix print format

* Fix type

* Fix warnings for LLVM

* Fix for wasm

* Fix for arm64

* Fix x86

* Iterator could be negative

* Fix a warning in decompose.c

* Fix warning for arm

* Fix warning for wasm only llvm code

* Correct a few iterator types

* Fix another incorrect iterator type

* Update src/mono/mono/mini/interp/transform.c

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

* Update src/mono/mono/mini/mini-generic-sharing.c

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

* Update src/mono/mono/mini/mini-generic-sharing.c

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

* Update src/mono/mono/mini/mini-generic-sharing.c

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>

* Address review feedback

* Remove other fixed warning.

* Use more accurate types when possible

Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    @fanyang-mono @lambdageek
    fanyang-mono and lambdageek authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    5529dc7 View commit details
    Browse the repository at this point in the history
Loading