[mono] Avoid calling mono_metadata_type_hash () on the container clas… #71734
Conversation
…s in mono_generic_class_hash (). If a class inherits from a generic instance instantiated with itself, then its possible for mono_generic_class_hash () to be called while the container class is not fully initialized yet, i.e. byval_arg.type is 0. This would cause the generic class to change its hash. Fixes dotnet#71424.
|
@steveisok we should backport this one, I think |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2629365015 |
|
@vargaz an error occurred while backporting to release/6.0, please check the run log for details! Error: @vargaz is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your Microsoft team membership visibility is set to Public on https://github.com/orgs/microsoft/people?query=vargaz |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2629462783 |
|
@vargaz an error occurred while backporting to release/6.0, please check the run log for details! Error: @vargaz is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your Microsoft team membership visibility is set to Public on https://github.com/orgs/microsoft/people?query=vargaz |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2629481479 |
|
@vargaz an error occurred while backporting to release/6.0, please check the run log for details! Error: @vargaz is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your Microsoft team membership visibility is set to Public on https://github.com/orgs/microsoft/people?query=vargaz |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2629819966 |
|
Just curious why automated test is not possible? only possible to repro in MAUI? |
|
Tried for a while to create one, but couldn't. |
…s in mono_generic_class_hash ().
If a class inherits from a generic instance instantiated with itself, then its possible
for mono_generic_class_hash () to be called while the container class is not fully
initialized yet, i.e. byval_arg.type is 0. This would cause the generic class to change
its hash.
Fixes #71424.