Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3d9da91a97
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0d44aea369
Choose a head ref
  • 19 commits
  • 158 files changed
  • 14 contributors

Commits on Sep 17, 2024

  1. [release/9.0-rc2] NRBF Fuzzer and bug fixes (#107788)

    * [NRBF] Don't use Unsafe.As when decoding DateTime(s) (#105749)
    
    * Add NrbfDecoder Fuzzer (#107385)
    
    * [NRBF] Fix bugs discovered by the fuzzer (#107368)
    
    * bug #1: don't allow for values out of the SerializationRecordType enum range
    
    * bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type
    
    * bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)
    
    * bug #4: document the fact that IOException can be thrown
    
    * bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails
    
    * bug #6: 0 and 17 are illegal values for PrimitiveType enum
    
    * bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
    # Conflicts:
    #	src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/NrbfDecoder.cs
    
    * [NRBF] throw SerializationException when a surrogate character is read (#107532)
    
     (so far an ArgumentException was thrown)
    
    * [NRBF] Fuzzing non-seekable stream input (#107605)
    
    * [NRBF] More bug fixes (#107682)
    
    - Don't use `Debug.Fail` not followed by an exception (it may cause problems for apps deployed in Debug)
    - avoid Int32 overflow
    - throw for unexpected enum values just in case parsing has not rejected them
    - validate the number of chars read by BinaryReader.ReadChars
    - pass serialization record id to ex message
    - return false rather than throw EndOfStreamException when provided Stream has not enough data
    - don't restore the position in finally 
    - limit max SZ and MD array length to Array.MaxLength, stop using LinkedList<T> as List<T> will be able to hold all elements now
    - remove internal enum values that were always illegal, but needed to be handled everywhere
    - Fix DebuggerDisplay
    
    * [NRBF] Comments and bug fixes from internal code review (#107735)
    
    * copy comments and asserts from Levis internal code review
    
    * apply Levis suggestion: don't store Array.MaxLength as a const, as it may change in the future
    
    * add missing and fix some of the existing comments
    
    * first bug fix: SerializationRecord.TypeNameMatches should throw ArgumentNullException for null Type argument
    
    * second bug fix: SerializationRecord.TypeNameMatches should know the difference between SZArray and single-dimension, non-zero offset arrays (example: int[] and int[*])
    
    * third bug fix: don't cast bytes to booleans
    
    * fourth bug fix: don't cast bytes to DateTimes
    
    * add one test case that I've forgot in previous PR
    # Conflicts:
    #	src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/SerializationRecord.cs
    
    * [NRBF] Address issues discovered by Threat Model  (#106629)
    
    * introduce ArrayRecord.FlattenedLength
    
    * do not include invalid Type or Assembly names in the exception messages, as it's most likely corrupted/tampered/malicious data and could be used as a vector of attack.
    
    * It is possible to have binary array records have an element type of array without being marked as jagged
    
    ---------
    
    Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
    adamsitnik and buyaa-n authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fde8a3b View commit details
    Browse the repository at this point in the history
  2. [release/9.0-rc2] Update dependencies from dotnet/source-build-refere…

    …nce-packages (#107939)
    
    * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20240917.3
    
    Microsoft.SourceBuild.Intermediate.source-build-reference-packages
     From Version 9.0.0-alpha.1.24466.2 -> To Version 9.0.0-alpha.1.24467.3
    
    * Bump private intellisense version
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
    3 people authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    50ec9ef View commit details
    Browse the repository at this point in the history
  3. Update dependencies from https://github.com/dotnet/emsdk build 202409…

    …16.4 (#107935)
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
     From Version 9.0.0-rc.2.24464.3 -> To Version 9.0.0-rc.2.24466.4
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7688892 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Mark the System.Formats.Nrbf assembly as [Experimental] with SYSLIB50…

    …05 (#107950)
    
    Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
    github-actions[bot] and jeffhandley authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7e1c7c4 View commit details
    Browse the repository at this point in the history
  2. Update dependencies from https://github.com/dotnet/arcade build 20240…

    …916.2 (#107948)
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 9.0.0-beta.24463.2 -> To Version 9.0.0-beta.24466.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c478b2a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. [release/9.0-rc2] Replace VectorXx.Exp's edge case fallback with scal…

    …ar processing (#107942)
    
    * Replace VectorXx.Exp's edge case fallback with scalar processing
    
    The better, vectorized fix is more complex and can be done for .NET 10.
    
    * Revert addition to Helpers.IsEqualWithTolerance
    
    ---------
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    github-actions[bot] and stephentoub authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    15e4423 View commit details
    Browse the repository at this point in the history
  2. Update dependencies from https://github.com/dotnet/icu build 20240917…

    ….2 (#107960)
    
    Microsoft.NETCore.Runtime.ICU.Transport
     From Version 9.0.0-rc.2.24466.2 -> To Version 9.0.0-rc.2.24467.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0cd7306 View commit details
    Browse the repository at this point in the history
  3. Update configure.h.in (#107955)

    This symbol should be defined/not defined instead of defined as 0 or 1.
    
    Fixes commit info for when running dotnet --info.
    
    Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
    github-actions[bot] and jkoritzinsky authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8d6a573 View commit details
    Browse the repository at this point in the history
  4. Update dependencies from https://github.com/dotnet/emsdk build 202409…

    …18.8 (#108001)
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport
     From Version 9.0.0-rc.2.24466.4 -> To Version 9.0.0-rc.2.24468.8
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    25e7a89 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    69aa2f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Configuration menu
    Copy the full SHA
    153304e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    4e1a9ba View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. [release/9.0] Update dependencies from dotnet/runtime (#108140)

    * Update dependencies from https://github.com/dotnet/runtime build 20240920.3
    
    Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
     From Version 9.0.0-rc.2.24463.7 -> To Version 9.0.0-rtm.24470.3
    
    * Update dependencies from https://github.com/dotnet/runtime build 20240923.2
    
    Microsoft.DotNet.ILCompiler , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
     From Version 9.0.0-rtm.24470.3 -> To Version 9.0.0-rtm.24473.2
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    3 people authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2c4266c View commit details
    Browse the repository at this point in the history
  2. Fix createdump 'stack smashing detected' error on arm64 (#108208)

    The changes from PR #91865 were reverted by PR #95433.
    
    This change restores the fix from PR #91865 by changing the size back to SpecialDiagInfoSize
    but uses the 4 parameter MemoryRegion constructor that doesn't assert the address/size is on
    a PAGE_SIZE alignment (PR #95433).
    
    Issue: #108023
    
    Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bad31df View commit details
    Browse the repository at this point in the history
  3. [release/9.0] [browser] Fix fingerprinting and loadAllSatelliteResour…

    …ces=true (#108198)
    
    * Set virtualPath for resource show loaded with loadAllSatelliteResources=true
    
    * WBT using loadAllSatelliteResources=true
    
    * Fix passing parameter to test added in #108190
    
    * Update expected test outputs
    
    ---------
    
    Co-authored-by: Marek Fišera <mara@neptuo.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    faf43ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9b237d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge pull request #108006 from dotnet/merge/release/9.0-rc2-to-relea…

    …se/9.0
    
    [automated] Merge branch 'release/9.0-rc2' => 'release/9.0'
    carlossanlop authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1b7ce8b View commit details
    Browse the repository at this point in the history
  2. More doc updates for source-of-truth assemblies (#107810) (#108257)

    Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
    carlossanlop and gewarren authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d3134eb View commit details
    Browse the repository at this point in the history
  3. Update dependencies from https://github.com/dotnet/source-build-refer…

    …ence-packages build 20240918.2 (#108142)
    
    Microsoft.SourceBuild.Intermediate.source-build-reference-packages
     From Version 9.0.0-alpha.1.24467.3 -> To Version 9.0.0-alpha.1.24468.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0d44aea View commit details
    Browse the repository at this point in the history
Loading