[release/9.0-rc2] Update configure.h.in#107955
Merged
carlossanlop merged 1 commit intorelease/9.0-rc2from Sep 19, 2024
Merged
Conversation
This symbol should be defined/not defined instead of defined as 0 or 1. Fixes commit info for when running dotnet --info.
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
jeffschwMSFT
approved these changes
Sep 17, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in rc2
hoyosjs
approved these changes
Sep 17, 2024
Contributor
|
/ba-g Dead lettering in System.Collections.Specialized.Tests (I've been seeing it in other PRs in the exact same tests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107954 to release/9.0-rc2
/cc @jkoritzinsky
Customer Impact
dotnet --infooutputs the following info for the host:It should output the commit ID in the commit field.
Regression
Regressed in 9.0-preview 6
Testing
Manual build validation
Risk
Low. This only affects
dotnet --info.