Remove obfuscated dlls from Compiler.Test.Resources#82286
Merged
akhera99 merged 3 commits intodotnet:mainfrom Feb 5, 2026
Merged
Remove obfuscated dlls from Compiler.Test.Resources#82286akhera99 merged 3 commits intodotnet:mainfrom
akhera99 merged 3 commits intodotnet:mainfrom
Conversation
Member
|
The references exist, they're just obfuscated 😉 Edit: context emoji's are important |
3375434 to
b2d8ff6
Compare
dibarbet
approved these changes
Feb 4, 2026
jaredpar
approved these changes
Feb 4, 2026
dibarbet
approved these changes
Feb 4, 2026
Member
Author
|
/backport to release/dev18.0 |
Contributor
|
Started backporting to |
Member
Author
|
/backport to release/dev17.14 |
Contributor
|
Started backporting to |
Member
Author
|
/backport to release/dev17.12 |
Contributor
|
Started backporting to |
akhera99
added a commit
that referenced
this pull request
Feb 6, 2026
…#82304) Backport of #82286 to release/dev18.0 /cc @akhera99 ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] --------- Co-authored-by: Ankita Khera <ankitakhera@microsoft.com>
akhera99
added a commit
that referenced
this pull request
Feb 6, 2026
#82305) Backport of #82286 to release/dev17.14 /cc @akhera99 ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] --------- Co-authored-by: Ankita Khera <ankitakhera@microsoft.com>
akhera99
added a commit
to akhera99/roslyn
that referenced
this pull request
Feb 24, 2026
Excludes the test resources assembly from signing by setting CertificateName="None" since this is a non-shipping test utility assembl, it does not require signing. Also removes the dlls from the test resources since they're no longer used by any tests.
Member
|
/backport to release/dev18.3 |
Contributor
|
Started backporting to |
2 tasks
phil-allen-msft
pushed a commit
that referenced
this pull request
Feb 25, 2026
…#82524) Backport of #82286 to release/dev18.3 /cc @mmitche @akhera99 ## Customer Impact ## Regression - [ ] Yes - [ ] No [If yes, specify when the regression was introduced. Provide the PR or commit if known.] ## Testing [How was the fix verified? How was the issue missed previously? What tests were added?] ## Risk [High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] --------- Co-authored-by: Ankita Khera <ankitakhera@microsoft.com> Co-authored-by: Ankita Khera <40616383+akhera99@users.noreply.github.com>
jjonescz
added a commit
to jjonescz/roslyn
that referenced
this pull request
Apr 8, 2026
The scan service rejects the nupkg because it contains embedded obfuscated DLLs (Obfuscated.dll, Obfuscated2.dll) that trigger BlockingDetectionFound. Remove the DLLs (no test references them), add CertificateName=None in Signing.props, and add a SignCheckExclusionsFile.txt entry to skip post-build validation. Backport of PR dotnet#82286 (main) / PR dotnet#82306 (dev17.12). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jjonescz
added a commit
that referenced
this pull request
Apr 8, 2026
The scan service rejects the nupkg because it contains embedded obfuscated DLLs (Obfuscated.dll, Obfuscated2.dll) that trigger BlockingDetectionFound. Remove the DLLs (no test references them), add CertificateName=None in Signing.props, and add a SignCheckExclusionsFile.txt entry to skip post-build validation. Backport of PR #82286 (main) / PR #82306 (dev17.12). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excludes the test resources assembly from signing by setting CertificateName="None" since this is a non-shipping test utility assembl, it does not require signing. Also removes the dlls from the test resources since they're no longer used by any tests.