Skip to content

Disable roslyn-language-server packaging in VMR builds#82254

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/disable-packaging-for-language-server
Closed

Disable roslyn-language-server packaging in VMR builds#82254
Copilot wants to merge 3 commits into
mainfrom
copilot/disable-packaging-for-language-server

Conversation

Copilot AI commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

VMR builds produce incorrect roslyn-language-server packages. The VMR builds once per architecture and fails to aggregate RID-specific packages correctly, resulting in a metapackage that only references win-x64 instead of all 8 required RIDs.

Workaround: disable packaging in VMR until the orchestrator issue is fixed.

<IsPackable Condition="'$(DotNetBuildFromVMR)' != 'true'">true</IsPackable>

Upstream issue: dotnet/dotnet#4604

Original prompt

I would like you to workaround this issue - dotnet/dotnet#4604 by disabling packaging for the Microsoft.CodeAnalysis.LanguageServer project when building in the VMR


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Workaround for dotnet/dotnet#4604. The VMR builds this
once per architecture and does not correctly aggregate the packages when publishing.
Disable the package in VMR until there is a fix.

Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot AI changed the title [WIP] Disable packaging for Microsoft.CodeAnalysis.LanguageServer in VMR Disable roslyn-language-server packaging in VMR builds Feb 2, 2026
Copilot AI requested a review from dibarbet February 2, 2026 19:04
<!-- Workaround https://github.com/dotnet/dotnet/issues/4604.
The VMR builds this once per architecture and does not correctly aggregate the packages when publishing.
Disable the package in VMR until there is a fix -->
<IsPackable Condition="'$(DotNetBuildSourceOnly)' != 'true'">true</IsPackable>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot believe this should be DotNetBuildFromVMR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in de6006b. Changed to use DotNetBuildFromVMR instead of DotNetBuildSourceOnly.

Co-authored-by: dibarbet <5749229+dibarbet@users.noreply.github.com>
Copilot AI requested a review from dibarbet February 2, 2026 19:10
@dibarbet dibarbet marked this pull request as ready for review February 2, 2026 19:12
@dibarbet dibarbet requested a review from a team as a code owner February 2, 2026 19:12
@dibarbet dibarbet enabled auto-merge February 2, 2026 21:02
jkoritzinsky added a commit that referenced this pull request Feb 2, 2026
The Arcade SDK will provide RID filtering when required for a successful build in the VMR. This project does not need such filtering. It would only need such filtering in source-build, and this project is already disabled in source-build.

Fixes dotnet/dotnet#4604

Replaces #82254
@dibarbet dibarbet closed this Feb 3, 2026
auto-merge was automatically disabled February 3, 2026 03:46

Pull request was closed

@JoeRobich JoeRobich deleted the copilot/disable-packaging-for-language-server branch May 22, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants