Skip to content

Merge features/collection-expression-arguments to 'main'.#81924

Merged
CyrusNajmabadi merged 180 commits intomainfrom
features/collection-expression-arguments
Jan 21, 2026
Merged

Merge features/collection-expression-arguments to 'main'.#81924
CyrusNajmabadi merged 180 commits intomainfrom
features/collection-expression-arguments

Conversation

@CyrusNajmabadi
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Jan 8, 2026

Merges collection expression arguments implementation into main for next version of C#.

Closes #80613

CyrusNajmabadi and others added 30 commits November 13, 2024 03:06
…76003)

* Add WithElement syntax

* Generate code

* Add parsing

* Add binding bail out.

* Add specific error

* Add tests

* Add tests

* Add tests

* Add tests

* Add tests

* Add tests

* rename

* Add tests

* update switch

* add public apis

* add public apis

* success tests

* failure tests

* Fix

* Add docs

* REname

* Change loc string

* Change loc string

* Update src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs

* Update src/Compilers/CSharp/Test/Syntax/Parsing/CollectionExpressionParsingTests.cs

* Add tests

* Update src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs

* Fix generation

* Add prototype

* Add tests

* Add docS

* Report errors for every with element out of place

* Add tests

* No binding at all

* Remove

* REmove error code

* REmove error code
Update public api

Update error code
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review January 18, 2026 18:46
@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners January 18, 2026 18:46
@CyrusNajmabadi
Copy link
Contributor Author

This is the PR to merge collection-expr-args back into main. Once we have full test-plan signoff. @RikkiGibson @jcouv @333fred

@CyrusNajmabadi CyrusNajmabadi changed the title Features/collection expression arguments Merge features/collection-expression-arguments to 'main'. Jan 18, 2026
@@ -60,7 +60,6 @@ foreach (var x in new[] { 1, 2 })

See also https://github.com/dotnet/csharplang/issues/9750.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@jcouv jcouv added the Feature - Collection Arguments Collection expression with() arguments label Jan 20, 2026
@jcouv
Copy link
Member

jcouv commented Jan 20, 2026

LGTM, tagging @phil-allen-msft for approval to merge feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Collection Arguments Collection expression with() arguments Needs API Review Needs to be reviewed by the API review council VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test plan for "collection expression arguments" feature

7 participants