Unsafe evolution: check caller unsafe context for usages of some methods and properties#81581
Merged
jjonescz merged 10 commits intoDec 15, 2025
Merged
Conversation
333fred
reviewed
Dec 8, 2025
jcouv
reviewed
Dec 8, 2025
jcouv
reviewed
Dec 8, 2025
jcouv
reviewed
Dec 8, 2025
jcouv
reviewed
Dec 8, 2025
jcouv
reviewed
Dec 8, 2025
Member
|
It was not clear from the PR title "handle unsafe methods and properties" whether OHI scenarios would be included in this PR. Consider refining the title, as the PR is focused on checking the |
jcouv
reviewed
Dec 9, 2025
jcouv
reviewed
Dec 9, 2025
jcouv
reviewed
Dec 9, 2025
jcouv
left a comment
Member
There was a problem hiding this comment.
Done with review pass (commit 2) Will finish looking at the tests tomorrow
jcouv
reviewed
Dec 10, 2025
jcouv
reviewed
Dec 10, 2025
jcouv
reviewed
Dec 10, 2025
jcouv
left a comment
Member
There was a problem hiding this comment.
Done with review pass (commit 5)
333fred
reviewed
Dec 10, 2025
333fred
left a comment
Member
There was a problem hiding this comment.
Think my only comment left is on the error message.
Member
Author
|
@333fred for another look, thanks |
333fred
approved these changes
Dec 12, 2025
This was referenced Dec 15, 2025
jjonescz
added a commit
that referenced
this pull request
Dec 19, 2025
jjonescz
added a commit
that referenced
this pull request
Dec 19, 2025
Test plan: #81207 Follow up on #81581 (i.e., still only for methods and properties). Implements this speclet section: https://github.com/dotnet/csharplang/blob/80f7e032a3131f1d9c2c6822b8a03cf56eeda005/proposals/unsafe-evolution.md#compat-mode
jjonescz
added a commit
that referenced
this pull request
Jan 7, 2026
Test plan: #81207 Follow up on #81581 (i.e., still only for methods and properties). Implements this speclet section: https://github.com/dotnet/csharplang/blob/d4a7252e082927c9e6d6f1386d0bb46fa690db8b/proposals/unsafe-evolution.md#extern
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: #81207
More member kinds (besides methods and properties; and also some other types of methods, like synthesized methods) will be handled in a follow up (once this proof of concept is approved). OHI is also not handled in this PR.