SyntheticBoundNodeFactory: Remove ability to create arbitrary conversions #81569
Merged
AlekseyTs merged 1 commit intodotnet:mainfrom Dec 8, 2025
Merged
Conversation
…eFactory Language rules around conversions are getting more and more complex. At the same time Convert APIs in SyntheticBoundNodeFactory might confuse consumer into thinking that they are able to synthesize nodes for arbitrary conversions, which is not the case. This change removes one API and adds an assert to remaining API to verify that only conversions that are natively supported by Emit layer are coming through.
333fred
approved these changes
Dec 6, 2025
Comment on lines
+193
to
+194
| case ConversionKind.Boxing: | ||
| case ConversionKind.ExplicitReference: |
Member
There was a problem hiding this comment.
Minor nit:
Suggested change
| case ConversionKind.Boxing: | |
| case ConversionKind.ExplicitReference: | |
| case ConversionKind.ExplicitReference: | |
| case ConversionKind.Boxing: | |
| ``` #Resolved |
Contributor
Author
There was a problem hiding this comment.
The order of cases came from the function above
Contributor
Author
|
@RikkiGibson, @dotnet/roslyn-compiler For a second review |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Dec 9, 2025
* upstream/main: (221 commits) [main] Update dependencies from dotnet/roslyn (dotnet#81601) Update Roslyn.Diagnostics.Analyzers (dotnet#81599) Remove unnecessary lightup code Remove unnecessary lightup code Remove unnecessary lightup code Remove unnecessary lightup code Remove unnecessary lightup code Build NullableWalker.DebugVerifier: Explicitly visit `BoundCollectionExpressionSpreadElement.Conversion` (dotnet#81584) SyntheticBoundNodeFactory: Remove ability to create arbitrary conversions (dotnet#81569) Docs Tweak Remove dependency on Newtonsoft.Json from Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost (dotnet#81562) Simplify Apply suggestions from code review Make into theory Updates Add tests Add tests Improve go-to-def navigation in overload resolution failure cases ...
This was referenced Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language rules around conversions are getting more and more complex. At the same time Convert APIs in SyntheticBoundNodeFactory might confuse consumer into thinking that they are able to synthesize nodes for arbitrary conversions, which is not the case.
This change removes one API and adds an assert to remaining API to verify that only conversions that are natively supported by Emit layer are coming through.