Skip to content

Don't use an implicit-object if the lang version doesn't support it#77437

Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi:implicitObjectIntroVar
Mar 5, 2025
Merged

Don't use an implicit-object if the lang version doesn't support it#77437
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi:implicitObjectIntroVar

Conversation

@CyrusNajmabadi
Copy link
Contributor

Fixes #77428

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 5, 2025 15:33
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 5, 2025
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge March 5, 2025 17:22
@CyrusNajmabadi CyrusNajmabadi merged commit 531b504 into dotnet:main Mar 5, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the implicitObjectIntroVar branch March 5, 2025 18:05
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 5, 2025
JoeRobich added a commit to dotnet/vscode-csharp that referenced this pull request Mar 8, 2025
* Don't use an implicit-object if the lang version doesn't support it (PR: [#77437](dotnet/roslyn#77437))
* Fix issue where we were changing semantics when converting to a collection expr. (PR: [#77417](dotnet/roslyn#77417))
* Detect and emit more idiomatic null check patterns (PR: [#77412](dotnet/roslyn#77412))
* Partial events and constructors: IDE (PR: [#77337](dotnet/roslyn#77337))
* Simplify keyword recommenders. (PR: [#77396](dotnet/roslyn#77396))
* Remove async/await (PR: [#77397](dotnet/roslyn#77397))
* Preserve encoding during DocumentState updates (PR: [#77354](dotnet/roslyn#77354))
* Don't realize the SourceText in SyntaxTree.OverlapsHiddenPosition if not needed (PR: [#77334](dotnet/roslyn#77334))
* Handle ModuleCancellationTokenExpression in AbstractFlow visitor (PR: [#77310](dotnet/roslyn#77310))
* PERF: Reduce the number of nodes walked during import completion commit. (PR: [#77305](dotnet/roslyn#77305))
* Allow expression body refactorings on non empty selections (PR: [#76969](dotnet/roslyn#76969))
* Partial events and constructors: public API (PR: [#77202](dotnet/roslyn#77202))
* Refresh diagnostics when fading options change (PR: [#77322](dotnet/roslyn#77322))
* Reduce allocations during completion in FilterToVisibleAndBrowsableSymbols (PR: [#77315](dotnet/roslyn#77315))
* Change override completion to select text after updating the buffer. (PR: [#76983](dotnet/roslyn#76983))
* Fix false positive 'Unnecessary assignment of a value' (PR: [#77297](dotnet/roslyn#77297))
@jjonescz jjonescz modified the milestones: Next, 17.14 P3 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In C# 7.3, Introduce local for 'new xxx' can put CS8370

3 participants