Expose inline completion to Razor for cohosting#76293
Merged
davidwengier merged 1 commit intodotnet:mainfrom Dec 6, 2024
Merged
Expose inline completion to Razor for cohosting#76293davidwengier merged 1 commit intodotnet:mainfrom
davidwengier merged 1 commit intodotnet:mainfrom
Conversation
This was referenced Dec 6, 2024
dibarbet
approved these changes
Dec 6, 2024
This was referenced Dec 12, 2024
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Dec 16, 2024
Fixes #10744 Needs dotnet/roslyn#76293 to merge and a version bump, but you know the idea by now I'm sure. Pretty straight forward. The test snippet file was copied directly from Roslyns own inline completion tests. Turns out our existing inline completion has zero tests, and was inadvertently turned off in the first cohosting completion PR 🤦♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roslyn side of dotnet/razor#10744