Skip to content

Merge main to VBOverloadResolutionPriority#75876

Merged
AlekseyTs merged 25 commits intofeatures/VBOverloadResolutionPriorityfrom
TemporarySnapshot
Nov 12, 2024
Merged

Merge main to VBOverloadResolutionPriority#75876
AlekseyTs merged 25 commits intofeatures/VBOverloadResolutionPriorityfrom
TemporarySnapshot

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

Youssef1313 and others added 25 commits April 3, 2022 09:19
* Move HasHome out of Binder

* Fixup references

* Add a comment
Upgrade to latest structured logger binaries and see if that addresses the failure to read binary logs.
* Make VBCSCompiler pipe name insensitive to casing of the path

* Improve comment wording

Co-authored-by: Jared Parsons <jared@paranoidcoding.org>

---------

Co-authored-by: Jared Parsons <jared@paranoidcoding.org>
The GetTags calls into our taggers require passing back an IEnumerable. Previously, we created a SegmentedList to hold all the data and then passed that back. However, that suffers from not being able to add back the returned list into a pool. Instead, switch to using yield return over the populated segmented list as that will allow the list to be freed back to the pool upon completion.

Utilizing the yield state machinery does incur an allocation, but this should be a much smaller allocation than the potentially very large arrays that our taggers were returning.
@AlekseyTs AlekseyTs requested review from a team as code owners November 12, 2024 22:32
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants