Conversation
Upgrade to latest structured logger binaries and see if that addresses the failure to read binary logs.
333fred
approved these changes
Nov 12, 2024
RikkiGibson
approved these changes
Nov 12, 2024
jjonescz
reviewed
Nov 12, 2024
| --> | ||
| <PackageVersion Include="Microsoft.Win32.Registry" Version="5.0.0" /> | ||
| <PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.169" /> | ||
| <PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.386" /> |
Member
There was a problem hiding this comment.
Suggested change
| <PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.386" /> | |
| <PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.350" /> |
Member
Author
There was a problem hiding this comment.
Why that version vs. latest?
Member
There was a problem hiding this comment.
But I don't know whether 350 is new enough to resolve the original issue
Member
There was a problem hiding this comment.
It looks like rerun of the CI made the error go away. Interesting.
This was referenced Nov 15, 2024
JoeRobich
added a commit
that referenced
this pull request
Nov 21, 2024
Backports #75865 to fix Correctness_Build_Artifacts CI.
jjonescz
pushed a commit
to jjonescz/roslyn
that referenced
this pull request
Nov 25, 2024
Upgrade to latest structured logger binaries and see if that addresses the failure to read binary logs.
jjonescz
pushed a commit
to jjonescz/roslyn
that referenced
this pull request
Nov 25, 2024
Upgrade to latest structured logger binaries and see if that addresses the failure to read binary logs.
This was referenced Nov 25, 2024
jjonescz
pushed a commit
that referenced
this pull request
Nov 27, 2024
Upgrade to latest structured logger binaries and see if that addresses the failure to read binary logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to latest structured logger binaries and see if that addresses the failure to read binary logs.