Support unbound generic types in 'nameof' operator.#75368

Merged

CyrusNajmabadi merged 51 commits intodotnet:mainfrom

CyrusNajmabadi:openTypes

Nov 19, 2024

Contributor

CyrusNajmabadi commented Oct 3, 2024 •

edited by jcouv

Loading

Speclet: https://github.com/dotnet/csharplang/blob/main/proposals/csharp-14.0/unbound-generic-types-in-nameof.md
Championed proposal: dotnet/csharplang#8480

CyrusNajmabadi added 10 commits

October 3, 2024 11:22


          Add initial tests

b363549


          Initial work

f1f276b


          more working

d5d1423


          Better parsing

f16971d


          more work

6d9a068


          names

b4ff542


          nesting

092b89c


          Fixup tests

d0b2d12


          Fixup tests

2d0155a


          Fixup tests

db46266

ghost added Area-Compilers untriaged labels


          Fix check

074bd23

jnm2 mentioned this pull request

[Proposal]: Unbound generic types in nameof dotnet/csharplang#8480

Closed

6 tasks

CyrusNajmabadi added 6 commits

October 8, 2024 11:46


          Merge remote-tracking branch 'upstream/main' into openTypes

52dd592


          Fix test

08e46f4


          Merge branch 'main' into openTypes

5f1fd05


          Merge remote-tracking branch 'upstream/main' into openTypes

bbdb37e


          message id

2198c85


          Merge branch 'main' into openTypes

ce2286a

CyrusNajmabadi marked this pull request as ready for review

November 4, 2024 21:30

CyrusNajmabadi requested a review from a team as a code owner

November 4, 2024 21:30

CyrusNajmabadi changed the title ~~WIP: Support unbound generic types in 'nameof' operator.~~ Support unbound generic types in 'nameof' operator.

jcouv reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Binder/Binder_Symbols.cs Outdated Show resolved Hide resolved

jcouv reviewed

View reviewed changes

src/Compilers/CSharp/Test/Semantic/Semantics/NameOfTests.cs Show resolved Hide resolved

jcouv reviewed

View reviewed changes

src/Compilers/CSharp/Test/Semantic/Semantics/NameOfTests.cs Outdated Show resolved Hide resolved

jcouv reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Parser/LanguageParser.cs Show resolved Hide resolved

jcouv reviewed

View reviewed changes

src/Compilers/CSharp/Test/Semantic/Semantics/NameOfTests.cs Outdated Show resolved Hide resolved

jcouv reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Parser/LanguageParser.cs Outdated Show resolved Hide resolved

jcouv reviewed

View reviewed changes

Member

jcouv left a comment

Done with review pass (iteration 17)

CyrusNajmabadi added 2 commits

November 19, 2024 09:09


          do not use expr body or out var

30c1a45


          Add tesets

efeea4c

CyrusNajmabadi requested a review from AlekseyTs

November 19, 2024 17:27


          Adding tests

f77d4d0

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Portable/Binder/Binder_Symbols.cs Show resolved Hide resolved


          use explicit else clause

0a3e50a

Contributor

AlekseyTs commented Nov 19, 2024

It feels like we would want to have similar relaxation in VB

Seems like it would be nice there as well. If someone wants to champion that, i'd support it.

If you are not planning to adjust VB, please open an issue to follow up and CC @KathleenDollard on it.

CyrusNajmabadi mentioned this pull request

VB: Support unbound generic types in 'nameof' operator. #75975

Open

Contributor Author

CyrusNajmabadi commented Nov 19, 2024

Opened #75975

AlekseyTs reviewed

View reviewed changes

src/Compilers/CSharp/Test/Semantic/Semantics/NameOfTests.cs Outdated Show resolved Hide resolved

AlekseyTs reviewed

View reviewed changes

src/Compilers/Test/Utilities/CSharp/Extensions.cs Outdated Show resolved Hide resolved

AlekseyTs reviewed

View reviewed changes

src/Compilers/Test/Utilities/CSharp/Extensions.cs Outdated Show resolved Hide resolved

CyrusNajmabadi added 2 commits

November 19, 2024 10:18


          validate runtime behavior

21d4a4e


          Do not use expression bodies or patterns

0be4c20

AlekseyTs approved these changes

View reviewed changes

Contributor

AlekseyTs left a comment

LGTM (commit 49)

Contributor

AlekseyTs commented Nov 19, 2024 •

edited

Loading

@CyrusNajmabadi Please squash commits while merging.

CyrusNajmabadi added 2 commits

November 19, 2024 11:00


          Add typeof teest

a0e8e13


          Add nameof teest

4d19b86

CyrusNajmabadi enabled auto-merge (squash)

November 19, 2024 19:02

CyrusNajmabadi mentioned this pull request

Add fixer to convert from bound generic types in nameof to unbound types. #75976

Merged

CyrusNajmabadi merged commit 6fb1f23 into dotnet:main

dotnet-policy-service bot added this to the Next milestone

CyrusNajmabadi deleted the openTypes branch

November 19, 2024 20:11

CyrusNajmabadi added a commit that referenced this pull request


          Add fixer to convert from bound generic types in nameof to unbound ty…

d7b111f

…pes. (#75976)

Followup to #75368. Adds an
analyzer/fixer to move to the new simpler form.

This was referenced Nov 22, 2024

[Automated] PRs inserted in VS build main-35521.35 #76014

Closed

[Automated] PRs inserted in VS build feature.debugger.main-35521.198 #76034

Closed

[Automated] PRs inserted in VS build feature.debugger.shadowDebug-35522.57 #76047

Closed

jjonescz modified the milestones: Next, 17.13 P2

BillWagner mentioned this pull request

[C# 14-Fundamentals and reference]: New Feature - nameof supports unbound generic types dotnet/docs#44182

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged