Update obsoletion to be an error for a few types#73226
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Apr 25, 2024
Merged
Update obsoletion to be an error for a few types#73226CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These types were obsoleted two years back in 17.4: #62998
We have legacy impls that literally do nothing (they just store the data in memory, and then return it when asked). This PR upgrades these from an obsoletion warning to an error (as part of our policy of gradual deprecation). Once this is out a while, we can then finally remove.
No usages of these types at all inside MS, or searching with grep.app.