Obsolete ITemporaryStorageService public APIs#62998
Merged
tmat merged 1 commit intodotnet:mainfrom Jul 29, 2022
Merged
Conversation
davidwengier
approved these changes
Jul 27, 2022
Member
davidwengier
left a comment
There was a problem hiding this comment.
VS Mac uses this.. I'm guessing you don't want me to just move them to use the internal interface instead, right? :D
Member
Author
|
I think they only use it to work around issue #22085 which I believe has been fixed. If so then we should be able to clean that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API shouldn't have been public in the first place. Roslyn shouldn't expose public APIs that provide general abstraction over a memory map.
Exports a trivial implementation of the obsoleted public APIs (copy of TrivialTemporaryStorageService).
Separating the public and internal interfaces will allow us to clean up the implementation.