Provide a sync path for 'AdditionalText' to prevent thread explosions.#6596
Merged
CyrusNajmabadi merged 1 commit intodotnet:masterfrom Nov 5, 2015
Merged
Conversation
Contributor
Author
|
Tagging @dotnet/roslyn-ide |
02a30c7 to
ba5e0a5
Compare
Member
|
👍. @Pilchie, @CyrusNajmabadi makes a good question -- this is potentially a significant perf improvement, we assume stabilization is locked at this point? |
Contributor
Author
|
Since no one has reported this issue but me, i think we don't need to take this for Update1. |
Member
|
👍 for master. I don't think this meets the bar for |
Member
Contributor
|
Yep Sam just stopped by the next table :) 👍 |
CyrusNajmabadi
added a commit
that referenced
this pull request
Nov 5, 2015
Provide a sync path for 'AdditionalText' to prevent thread explosions.
Contributor
|
It sounds like this could be the source of crushing slowdowns when enabling analyzers in one of the larger projects I work on. I'm currently investigating whether this behavior is actually what we see in that case, and also what we can do in our analyzers to work around the issue (DotNetAnalyzers/StyleCopAnalyzers#1736). |
sharwell
added a commit
to sharwell/StyleCopAnalyzers
that referenced
this pull request
Nov 8, 2015
github-actions bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
Generate syntax lists with the correct type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.