Enable rich LSIF hover information.#64580
Merged
NTaylorMullen merged 3 commits intomainfrom Oct 10, 2022
Merged
Conversation
- This changeset adds a fake set of LSP client capabilities that the LSIF generator can pass into corresponding APIs. I've currently filled the capabilities with hover based information so that underlying systems can see that clients support Markdown and therefore. - Updated tests to reflect the new behavior. ## Before  ## After 
dibarbet
approved these changes
Oct 7, 2022
mohaimenhasan
approved these changes
Oct 8, 2022
mohaimenhasan
left a comment
There was a problem hiding this comment.
So cool !! Thank you for updating this !!
Author
|
Found I had broken some tests, all should be good now! |
jasonmalinowski
approved these changes
Oct 8, 2022
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Oct 10, 2022
* upstream/main: (252 commits) Use the source-built version of ref packs and don't use app host when building in source-build (dotnet#64055) Enable rich LSIF hover information. (dotnet#64580) Add ChecksumAlgorithm to project snapshot (dotnet#62840) Utility for uploading artifact on test failure (dotnet#64578) Enable diagnostics Revert "Remove unused TS brace completion code" Publish additional packages to vssdk feed (dotnet#64571) spelling Move check Simplify SymbolKey implementation lint Update publish data to test PR validation fix (dotnet#64559) Simplify Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/SymbolKey/SymbolKey.cs Lint Proper equality checks Update src/Workspaces/Remote/Core/RemoteCallback.cs Revert "Not wait for solution crawler because it can be very busy" Add and use TargetFramework.Net70 (dotnet#64490) Not wait for solution crawler because it can be very busy ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After