Revert and fix the stackoverflow when search local function.#63473
Merged
Cosifne merged 4 commits intodotnet:mainfrom Aug 18, 2022
Merged
Revert and fix the stackoverflow when search local function.#63473Cosifne merged 4 commits intodotnet:mainfrom
Cosifne merged 4 commits intodotnet:mainfrom
Conversation
…ocalFuncindexing"" This reverts commit 2fe5202.
genlu
reviewed
Aug 18, 2022
src/Workspaces/CSharp/Portable/FindSymbols/CSharpDeclaredSymbolInfoFactoryService.cs
Outdated
Show resolved
Hide resolved
genlu
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three commit:
2 & 3. Fix the issue in the original commit. They are cherry-picked from Change the search of local function to non-recursive version #63338