Change the search of local function to non-recursive version#63338
Closed
Cosifne wants to merge 2 commits intodotnet:mainfrom
Closed
Change the search of local function to non-recursive version#63338Cosifne wants to merge 2 commits intodotnet:mainfrom
Cosifne wants to merge 2 commits intodotnet:mainfrom
Conversation
ryzngard
approved these changes
Aug 11, 2022
genlu
approved these changes
Aug 11, 2022
Contributor
|
Can we have a test for this? |
src/Workspaces/CSharp/Portable/FindSymbols/CSharpDeclaredSymbolInfoFactoryService.cs
Outdated
Show resolved
Hide resolved
Member
Author
Fred and David B have done a great job to get a code sample to reproduce this. And I am preparing the test |
Member
Author
|
Update for the test: |
3 tasks
CyrusNajmabadi
approved these changes
Aug 13, 2022
Member
Member
Author
|
This is checked in the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1582837
@ryzngard and @dibarbet investigate this and it looks like caused by the stackoverflow in the recursive function.