Delete checks for IsInCommandLineMode#62951
Merged
jasonmalinowski merged 1 commit intodotnet:release/dev17.4from Jul 27, 2022
Merged
Delete checks for IsInCommandLineMode#62951jasonmalinowski merged 1 commit intodotnet:release/dev17.4from
jasonmalinowski merged 1 commit intodotnet:release/dev17.4from
Conversation
It's unclear to me why these checks are necessary; devenv /build functions just fine without them. But since this code is expected to be free-threaded, it can cause deadlocks since this is marshalling behind the covers.
ryzngard
approved these changes
Jul 26, 2022
CyrusNajmabadi
approved these changes
Jul 26, 2022
Member
|
For .NET Project System projects, we'll use dotnet/project-system#8347 to prevent initializing the Language Service when running in command line mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unclear to me why these checks are necessary; devenv /build functions just fine without them. But since this code is expected to be free-threaded, it can cause deadlocks since this is marshalling behind the covers.