Skip to content

Don't activate the language service in command line mode#8347

Merged
ocallesp merged 1 commit intodotnet:mainfrom
drewnoakes:fix-3832-no-lang-svc-in-cmd-line-mode
Aug 22, 2022
Merged

Don't activate the language service in command line mode#8347
ocallesp merged 1 commit intodotnet:mainfrom
drewnoakes:fix-3832-no-lang-svc-in-cmd-line-mode

Conversation

@drewnoakes
Copy link
Copy Markdown
Member

@drewnoakes drewnoakes commented Jul 25, 2022

Fixes #3832.

When VS is running in command line mode (i.e. devenv.exe /build) we don't need to fire up the language service.

@drewnoakes drewnoakes added Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc Tenet-Performance This issue affects the "Performance" tenet. Performance-Scenario-Build This issue affects build performance. labels Jul 25, 2022
@drewnoakes drewnoakes added this to the 17.4 milestone Jul 25, 2022
@ghost ghost added the Performance-Scenario-General This issue affects performance in general. label Jul 25, 2022
@drewnoakes
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@drewnoakes drewnoakes marked this pull request as ready for review July 26, 2022 02:57
@drewnoakes drewnoakes requested a review from a team as a code owner July 26, 2022 02:57
@ocallesp ocallesp merged commit 6fbe032 into dotnet:main Aug 22, 2022
@drewnoakes drewnoakes deleted the fix-3832-no-lang-svc-in-cmd-line-mode branch August 31, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature-Language-Service Populating the Roslyn workspace with references, source files, analyzers, etc Performance-Scenario-Build This issue affects build performance. Performance-Scenario-General This issue affects performance in general. Tenet-Performance This issue affects the "Performance" tenet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop initializing the language service on command line builds

6 participants