Remove unnecessary tracking of unmatched parameters in method invocation escape analysis#62847
Merged
cston merged 2 commits intodotnet:mainfrom Jul 26, 2022
Merged
Remove unnecessary tracking of unmatched parameters in method invocation escape analysis#62847cston merged 2 commits intodotnet:mainfrom
cston merged 2 commits intodotnet:mainfrom
Conversation
…ion escape analysis
Contributor
Author
|
@dotnet/roslyn-compiler, please review. |
RikkiGibson
reviewed
Jul 22, 2022
| } | ||
|
|
||
| #if DEBUG | ||
| private static bool AllParametersHaveArguments( |
Member
There was a problem hiding this comment.
It looks like we don't create arguments for params arrays during binding. #49602
Consider testing a case like:
using System;
Span<int> M1(Span<int> input, params object[] arr) { return input; }
Span<int> M2()
{
return M1(stackalloc int[] { 1, 2, 3 });
}We might want to adjust this step to ensure that all parameters which may factor into escape analysis have arguments. Or just specifically permit a parameter with IsParams == true && Type.TypeKind == TypeKind.Array here, since that's likely the only kind we will miss.
#Resolved
Contributor
Author
|
@dotnet/roslyn-compiler, please review a small change to escape analysis, to simplify changes going forward. |
333fred
approved these changes
Jul 26, 2022
This was referenced Jul 28, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62834.