Skip to content

Don't offer '??=' for pointer types#62476

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Youssef1313:issues/62473
Jul 7, 2022
Merged

Don't offer '??=' for pointer types#62476
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Youssef1313:issues/62473

Conversation

@Youssef1313
Copy link
Member

Fixes #62473

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 7, 2022 19:23
@ghost ghost added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 7, 2022
// allows ??= for pointers in future. It should be kept in 'Preview'.
// If the test failed because language added support and this is no longer
// an error. The behavior for test 'TestPointer' below should be updated as well to suggest ??=
// Note that, when ??= is supported for pointers, the analyzer should check the language version which supports it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nifty idea!

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge (squash) July 7, 2022 19:26
@CyrusNajmabadi CyrusNajmabadi merged commit aa09e7b into dotnet:main Jul 7, 2022
@ghost ghost added this to the Next milestone Jul 7, 2022
@Youssef1313 Youssef1313 deleted the issues/62473 branch July 7, 2022 21:06
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 7, 2022
* upstream/main: (62 commits)
  Prevent assert from being hit (dotnet#62366)
  Don't offer '??=' for pointer types (dotnet#62476)
  Integrate generator times into /reportAnalyzer (dotnet#61661)
  Switch to a callback for cleaning up resources instead of passing in an explicit IDisposable. (dotnet#62373)
  Filter trees to only those containing global-usings or attributes prior to analyzing them. (dotnet#62444)
  Update PublishData.json
  Complete 'file' support for `SyntaxGenerator` (dotnet#62413)
  Apply changes directly to text buffer (dotnet#62337)
  Remove LangVer check from extended nameof binding (dotnet#62339)
  Fixed shared project file error (dotnet#62466)
  Handle new error codes
  Use MSBuid generated property for package path
  Exclude BCL libraries from Roslyn vsix
  Bump the integration test timeouts a bit
  Skip the balanced switch dispatch optimization for patterns on floating-point inputs (dotnet#62322)
  Test helpers shouldn't escape quotes by default (dotnet#62321)
  Reuse prior TableEntry values in the increment NodeTable builder if possible. (dotnet#62320)
  Install 3.1 runtime for SBOM tool
  Generate VS SBOM during official build.
  Minor refactoring in 'required' handling for override completion (dotnet#62422)
  ...
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDE0074 is offered for pointers

3 participants