Snap main to release/dev17.3#62195
Merged
RikkiGibson merged 1025 commits intorelease/dev17.3from Jun 28, 2022
Merged
Conversation
Simplify FAR impl wrt searching for global namespaces
Avoid NullReferenceException in Pick Members dialog
Simplify lambda expressions
Actually return filtered items for default implementation
NRT enable symbolfinder/find-refs code.
…rting NFE (#61792) * Convert connection lost exceptions to cancellations to avoid overreporting NFE * Typo and comment * Feedback * Refactoring
* Avoid accessing Document from formatter services * Push async higher * Split file * Rename
Recently we enabled FixAll functionality for a bunch of code refactorings. We have been seen intermittent failures in CI for the FixAll tests added for this. I was able to reproduce the failures locally quite consistently by running the test under a loop with thousands of iterations. Upon investigation it was found that when the test fails, the [underlying CWT](https://github.com/dotnet/roslyn/blob/73de4e98d3020c72a2eef479d267357c15332d80/src/Compilers/Core/Portable/Syntax/SyntaxNodeExtensions_Tracking.cs#L18) used by TrackNodes functionality seems to have cleared the entries for nodes requested to be tracked by this FixAll operations. Adding a ToArray invocation to the tracked nodes to realize the nodes into an array seems to ensure that this doesn't happen and the test passes consistently after this change. Ideally, we would have expected the `SyntaxEditor.OriginalRoot` to keep all the nodes in the original tree alive, but that doesn't seem to be the case. Long term, we may want to consider adding a new TrackNodes API that does the tracking using dictionaries instead of CWTs and returns a disposable tracker object, such that the caller explicitly controls the lifetime of the tracking.
* Add support for additional file diagnostics in workspace pull * fix formatting * Fix more formatting
* Handle error scenarios with duplicate required fields Fixes #62062.
Update 'use coalece assignment' fixer to support additional common use case.
…ain-to-release/dev17.3
Cosifne
approved these changes
Jun 28, 2022
Member
|
@RikkiGibson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.