Revert "Read syntax tree, source text and options synchronously in command handlers"#62189
Merged
RikkiGibson merged 1 commit intomainfrom Jun 28, 2022
Merged
Revert "Read syntax tree, source text and options synchronously in command handlers"#62189RikkiGibson merged 1 commit intomainfrom
RikkiGibson merged 1 commit intomainfrom
Conversation
Member
|
@RikkiGibson: are you able to clarify what's different between that "expected" and "actual" on the test there? |
Member
|
Ah, found the diff: Rollback may make sense, since the PR changed how we are handling formatting options. |
Member
Author
|
No, but more detail should be available in the internal links. Most likely, there's a difference in indentation which isn't showing up (maybe due to round-tripping the result text through HTML?) edit: too slow! 😄 |
Member
|
Sounds good. Seems like we don't have a test covering this case :( |
tmat
approved these changes
Jun 28, 2022
JoeRobich
approved these changes
Jun 28, 2022
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jun 28, 2022
…ly in command handlers (dotnet#62002)" (dotnet#62189)" This reverts commit 791de28.
tmat
added a commit
that referenced
this pull request
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#62002 is suspected of introducing required test failures.
Last known good: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/407545#view=discussion
First known bad: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/407578#view=discussion
Revert validation: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=6344859&view=results
Failing tests:
Please advise whether the failures are plausibly connected with this PR, and if so, whether we should revert, or take a follow-up PR to fix, or adjust the test baseline on the VS side. @chsienki @tmat @CyrusNajmabadi.