Adjust caching logic when a NodeStateTable is empty#62068
Merged
jcouv merged 5 commits intodotnet:mainfrom Jun 29, 2022
Merged
Conversation
Member
Author
|
@chsienki @dotnet/roslyn-compiler for review. Thanks |
Member
Author
|
@cston @dotnet/roslyn-compiler for second review. Thanks |
cston
reviewed
Jun 27, 2022
| ctx.RegisterSourceOutput(compilationAndClasses, (context, ct) => validate(ct.Item1, ct.Item2)); | ||
| })); | ||
|
|
||
| // run the generator once, and check it was passed the parse options |
Contributor
cston
reviewed
Jun 27, 2022
| } | ||
|
|
||
| [Fact, WorkItem(57455, "https://github.com/dotnet/roslyn/issues/57455")] | ||
| public void RemoveTriggeringSyntaxAndVerifySyntaxTreeConsistentWithCompilation() |
Contributor
Member
Author
There was a problem hiding this comment.
We are verifying the syntax tree given to the SG comes from the correct compilation. So I would say "both".
cston
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57455
For context, here's the relevant logic in
BatchNode. What happened was thatsourceTablewould be empty (the new source removed the attribute, so no syntax is returned from this source), butsourceTable.IsCachedwould returntruewhich leads us to use the old entriesnewTable.TryUseCachedEntries(stopwatch.Elapsed, sourceInputs).