Clear ValueTracking on solution close#61815
Merged
ryzngard merged 11 commits intodotnet:mainfrom Jul 29, 2022
Merged
Conversation
dibarbet
reviewed
Jun 10, 2022
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingTreeViewModel.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingCommandHandler.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
This depends on #62257 getting in |
ryzngard
commented
Jul 7, 2022
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingCommandHandler.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingToolWindow.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingToolWindow.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingToolWindow.cs
Outdated
Show resolved
Hide resolved
…w.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
jasonmalinowski
approved these changes
Jul 28, 2022
src/VisualStudio/Core/Def/ValueTracking/ValueTrackingToolWindow.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+87
to
+91
| _ = _threadingContext.JoinableTaskFactory.RunAsync(async () => | ||
| { | ||
| await _threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(); | ||
| ViewModel.Roots.Clear(); | ||
| }); |
Member
There was a problem hiding this comment.
Do you want to wrap this with an async waiter for integration tests?
Contributor
Author
There was a problem hiding this comment.
afaik we don't have any integration tests for clearing solution/closing solution. If we add we definitely would need to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59423
When a solution closes, the value tracking data is no longer valid. Just get rid of it to not hold onto solution and symbol data for something no longer available to the user.