Skip to content

Temporarily disable editorconfig tests on linux#61018

Merged
dibarbet merged 2 commits intodotnet:mainfrom
dibarbet:disable_editorconfig_tests
Apr 28, 2022
Merged

Temporarily disable editorconfig tests on linux#61018
dibarbet merged 2 commits intodotnet:mainfrom
dibarbet:disable_editorconfig_tests

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Apr 28, 2022 •
edited
Loading

Tracking issue to re-enable

#61017

Due to failing runs, e.g.
https://dev.azure.com/dnceng/public/_build/results?buildId=1742521&view=ms.vss-test-web.build-test-results-tab&runId=47095474&resultId=157944&paneView=debug

Error message

System.UnauthorizedAccessException : Access to the path '/datadisks' is denied.
---- System.IO.IOException : Permission denied

Stack trace

   at System.IO.Enumeration.FileSystemEnumerator`1.Init()
   at System.IO.Enumeration.FileSystemEnumerableFactory.FileInfos(String directory, String expression, EnumerationOptions options, Boolean isNormalized)
   at System.IO.DirectoryInfo.InternalEnumerateInfos(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)
   at System.IO.DirectoryInfo.GetFiles(String searchPattern, EnumerationOptions enumerationOptions)
   at Microsoft.CodeAnalysis.BuildTasks.UnitTests.DotNetSdkTests.AppendExtraEditorConfigs(String[] expected, Boolean findEditorConfigs, Boolean findGlobalConfigs) in /_/src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs:line 570
   at Microsoft.CodeAnalysis.BuildTasks.UnitTests.DotNetSdkTests.TestDiscoverEditorConfigFilesCanBeDisabled() in /_/src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs:line 440
----- Inner Stack Trace -----

@dibarbet dibarbet requested a review from a team as a code owner April 28, 2022 18:54
@dibarbet dibarbet mentioned this pull request Apr 28, 2022
Open
@dibarbet dibarbet requested a review from a team April 28, 2022 19:06
AlekseyTs
AlekseyTs reviewed Apr 28, 2022
View reviewed changes
src/Compilers/Core/MSBuildTaskTests/DotNetSdkTests.cs Outdated
}

[ConditionalFact(typeof(DotNetSdkAvailable))]
[ConditionalFact(typeof(DotNetSdkAvailable), typeof(WindowsOnly))]
Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeof(WindowsOnly)

Consider adding a WorkItem attribute referencing the tracking issue to re-enable. Could be done in a separate PR in order to unblock CI sooner rather than later.

Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to all disabled tests.

AlekseyTs
AlekseyTs approved these changes Apr 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Apr 28, 2022

@dotnet/roslyn-compiler could use 1 more review on this test disabling :)

@AlekseyTs
Copy link
Copy Markdown
Contributor

AlekseyTs commented Apr 28, 2022

could use 1 more review on this test disabling :)

Test-only changes are good with one sign-off

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Apr 28, 2022

could use 1 more review on this test disabling :)

Test-only changes are good with one sign-off

ah good to know. THanks!!

@dibarbet dibarbet merged commit 1e8573a into dotnet:main Apr 28, 2022
@ghost ghost added this to the Next milestone Apr 28, 2022
@dibarbet dibarbet deleted the disable_editorconfig_tests branch April 29, 2022 00:12
dibarbet added a commit to dibarbet/roslyn that referenced this pull request Apr 29, 2022
@dibarbet
Temporarily disable editorconfig tests on linux (dotnet#61018)
c6e302c 
* Temporarily disable editorconfig tests on linux

* Add reason
JoeRobich added a commit that referenced this pull request Apr 29, 2022
@JoeRobich
Merge pull request #61031 from dibarbet/backport_test_disable
dfb40f6 
Temporarily disable editorconfig tests on linux (#61018)
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

+1 more reviewer

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers Area-Infrastructure

Projects

None yet

Milestone

17.3 P2

Development

Successfully merging this pull request may close these issues.

4 participants

@dibarbet @AlekseyTs @CyrusNajmabadi @Cosifne